[PATCH] D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run"
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 26 08:50:34 PDT 2017
delcypher added a comment.
> That race condition may indeed exist, in https://reviews.llvm.org/rL257268 @delcypher mentions one reason for the revert is "the lit per test timeout tests fail." Perhaps related? Do you have more information about when the test fails?
The test failure I referred to there was fixed by r257616 . It was an API problem with the psutil module which is used to implement the timeout
> How is it failing? If it's a race condition, we should fix the test.
Agreed. I suspect the issue might be running `test/Inputs/shtest-timeout/quick_then_slow.py` and `test/Input/shtest-timeout/slow.py` because they use hardcoded sleep times could be fragile.
TBH it's been so long since I looked at this that I can't remember the exact reason why `quick_then_slow.py` and `slow.py` exist. There's a good reason to test with internal/external shell because the per test timeout is implemented differently in those cases but I'm drawing a blank on why I added `quick_then_slow.py` and `slow.py`. Looking at http://reviews.llvm.org/D14706 doesn't seem to tell me why...
More information about the llvm-commits