[llvm] r309123 - [lit] Mark several of lit's tests XFAIL on Windows

Brian Gesiak via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 08:10:50 PDT 2017


Author: modocache
Date: Wed Jul 26 08:10:50 2017
New Revision: 309123

URL: http://llvm.org/viewvc/llvm-project?rev=309123&view=rev
Log:
[lit] Mark several of lit's tests XFAIL on Windows

Summary:
rL257221 attempted to run lit's own test suite continuously, but that
commit was reverted because lit's test suite does not pass on Windows.
Because lit's tests do not run continuously, they often regress.

In order to un-revert rL257221, mark lit tests that fail as XFAIL for
Windows platforms.

Test Plan:
On a Windows development environment, follow the instructions in
utils/lit/README.txt to run lit's test suite:

```
utils/lit/lit.py \
    --path /path/to/your/llvm/build/bin \
    utils/lit/tests
```

Verify that the test suite is run and a successful exit code is
returned.

Reviewers: mgorny, rnk, delcypher, beanz

Reviewed By: rnk

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D35879

Modified:
    llvm/trunk/utils/lit/tests/discovery.py
    llvm/trunk/utils/lit/tests/googletest-format.py
    llvm/trunk/utils/lit/tests/googletest-timeout.py
    llvm/trunk/utils/lit/tests/googletest-upstream-format.py
    llvm/trunk/utils/lit/tests/lit.cfg
    llvm/trunk/utils/lit/tests/max-failures.py
    llvm/trunk/utils/lit/tests/selecting.py
    llvm/trunk/utils/lit/tests/shtest-format.py
    llvm/trunk/utils/lit/tests/shtest-output-printing.py
    llvm/trunk/utils/lit/tests/shtest-shell.py
    llvm/trunk/utils/lit/tests/shtest-timeout.py
    llvm/trunk/utils/lit/tests/unit/TestRunner.py
    llvm/trunk/utils/lit/tests/unittest-adaptor.py

Modified: llvm/trunk/utils/lit/tests/discovery.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/discovery.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/discovery.py (original)
+++ llvm/trunk/utils/lit/tests/discovery.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the basic discovery process, including a sub-suite.
 #
+# PR33932
+# XFAIL: windows
+#
 # RUN: %{lit} %{inputs}/discovery \
 # RUN:   -j 1 --debug --show-tests --show-suites \
 # RUN:   -v > %t.out 2> %t.err

Modified: llvm/trunk/utils/lit/tests/googletest-format.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/googletest-format.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/googletest-format.py (original)
+++ llvm/trunk/utils/lit/tests/googletest-format.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the various features of the GoogleTest format.
 #
+# PR33933
+# XFAIL: windows
+#
 # RUN: not %{lit} -j 1 -v %{inputs}/googletest-format > %t.out
 # RUN: FileCheck < %t.out %s
 #

Modified: llvm/trunk/utils/lit/tests/googletest-timeout.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/googletest-timeout.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/googletest-timeout.py (original)
+++ llvm/trunk/utils/lit/tests/googletest-timeout.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # REQUIRES: python-psutil
 
+# PR33934
+# XFAIL: windows
+
 # Check that the per test timeout is enforced when running GTest tests.
 #
 # RUN: not %{lit} -j 1 -v %{inputs}/googletest-timeout --timeout=1 > %t.cmd.out

Modified: llvm/trunk/utils/lit/tests/googletest-upstream-format.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/googletest-upstream-format.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/googletest-upstream-format.py (original)
+++ llvm/trunk/utils/lit/tests/googletest-upstream-format.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the various features of the GoogleTest format.
 #
+# PR33935
+# XFAIL: windows
+#
 # RUN: not %{lit} -j 1 -v %{inputs}/googletest-upstream-format > %t.out
 # RUN: FileCheck < %t.out %s
 #

Modified: llvm/trunk/utils/lit/tests/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/lit.cfg?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/lit.cfg (original)
+++ llvm/trunk/utils/lit/tests/lit.cfg Wed Jul 26 08:10:50 2017
@@ -52,3 +52,6 @@ try:
 except ImportError:
     lit_config.warning('Could not import psutil. Some tests will be skipped and'
                        ' the --timeout command line argument will not work.')
+
+if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
+    config.available_features.add('windows')

Modified: llvm/trunk/utils/lit/tests/max-failures.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/max-failures.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/max-failures.py (original)
+++ llvm/trunk/utils/lit/tests/max-failures.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the behavior of --max-failures option.
 #
+# PR33941
+# XFAIL: windows
+#
 # RUN: not %{lit} -j 1 -v %{inputs}/shtest-shell > %t.out
 # RUN: not %{lit} --max-failures=1 -j 1 -v %{inputs}/shtest-shell >> %t.out
 # RUN: not %{lit} --max-failures=2 -j 1 -v %{inputs}/shtest-shell >> %t.out

Modified: llvm/trunk/utils/lit/tests/selecting.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/selecting.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/selecting.py (original)
+++ llvm/trunk/utils/lit/tests/selecting.py Wed Jul 26 08:10:50 2017
@@ -1,6 +1,8 @@
 # RUN: %{lit} %{inputs}/discovery | FileCheck --check-prefix=CHECK-BASIC %s
 # CHECK-BASIC: Testing: 5 tests
 
+# PR33937
+# XFAIL: windows
 
 # Check that regex-filtering works
 #

Modified: llvm/trunk/utils/lit/tests/shtest-format.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-format.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/shtest-format.py (original)
+++ llvm/trunk/utils/lit/tests/shtest-format.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the various features of the ShTest format.
 #
+# PR33939
+# XFAIL: windows
+#
 # RUN: not %{lit} -j 1 -v %{inputs}/shtest-format > %t.out
 # RUN: FileCheck < %t.out %s
 #

Modified: llvm/trunk/utils/lit/tests/shtest-output-printing.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-output-printing.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/shtest-output-printing.py (original)
+++ llvm/trunk/utils/lit/tests/shtest-output-printing.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the various features of the ShTest format.
 #
+# PR33938
+# XFAIL: windows
+#
 # RUN: not %{lit} -j 1 -v %{inputs}/shtest-output-printing > %t.out
 # RUN: FileCheck --input-file %t.out %s
 #

Modified: llvm/trunk/utils/lit/tests/shtest-shell.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-shell.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/shtest-shell.py (original)
+++ llvm/trunk/utils/lit/tests/shtest-shell.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the internal shell handling component of the ShTest format.
 #
+# PR33940
+# XFAIL: windows
+#
 # RUN: not %{lit} -j 1 -v %{inputs}/shtest-shell > %t.out
 # RUN: FileCheck --input-file %t.out %s
 #

Modified: llvm/trunk/utils/lit/tests/shtest-timeout.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-timeout.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/shtest-timeout.py (original)
+++ llvm/trunk/utils/lit/tests/shtest-timeout.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # REQUIRES: python-psutil
 
+# PR33944
+# XFAIL: windows
+
 # Test per test timeout using external shell
 # RUN: not %{lit} \
 # RUN: %{inputs}/shtest-timeout/infinite_loop.py \

Modified: llvm/trunk/utils/lit/tests/unit/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/unit/TestRunner.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/unit/TestRunner.py (original)
+++ llvm/trunk/utils/lit/tests/unit/TestRunner.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # RUN: %{python} %s
 #
+# PR33942
+# XFAIL: windows
+#
 # END.
 
 

Modified: llvm/trunk/utils/lit/tests/unittest-adaptor.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/unittest-adaptor.py?rev=309123&r1=309122&r2=309123&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/unittest-adaptor.py (original)
+++ llvm/trunk/utils/lit/tests/unittest-adaptor.py Wed Jul 26 08:10:50 2017
@@ -1,5 +1,8 @@
 # Check the lit adaption to run under unittest.
 #
+# PR33943
+# XFAIL: windows
+#
 # RUN: %{python} %s %{inputs}/unittest-adaptor 2> %t.err
 # RUN: FileCheck < %t.err %s
 #




More information about the llvm-commits mailing list