[llvm] r309122 - [lit] Fix type error for parallelism groups

Brian Gesiak via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 08:02:05 PDT 2017

Author: modocache
Date: Wed Jul 26 08:02:05 2017
New Revision: 309122

URL: http://llvm.org/viewvc/llvm-project?rev=309122&view=rev
[lit] Fix type error for parallelism groups

Whereas rL299560 and rL309071 call `parallelism_groups.items()`, under the
assumption that `parallelism_groups` is a `dict` type, the default
parameter for that attribute is a `list`. Change the default to a
`dict` for type correctness.

This regression in the unit tests would have been caught if the
unit tests were being run continously. It also would have been caught
if the lit project used a Python type checker such as `mypy`.

Test Plan:
As per the instructions in `utils/lit/README.txt`, run the lit unit
test suite:

utils/lit/lit.py \
    --path /path/to/your/llvm/build/bin \

Verify that the test `lit :: unit/TestRunner.py` fails before applying this
patch, but passes once this patch is applied.

Reviewers: mgorny, rnk, rafael

Reviewed By: mgorny

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D35878


Modified: llvm/trunk/utils/lit/lit/LitConfig.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/LitConfig.py?rev=309122&r1=309121&r2=309122&view=diff
--- llvm/trunk/utils/lit/lit/LitConfig.py (original)
+++ llvm/trunk/utils/lit/lit/LitConfig.py Wed Jul 26 08:02:05 2017
@@ -25,7 +25,7 @@ class LitConfig(object):
                  params, config_prefix = None,
                  maxIndividualTestTime = 0,
                  maxFailures = None,
-                 parallelism_groups = [],
+                 parallelism_groups = {},
                  echo_all_commands = False):
         # The name of the test runner.
         self.progname = progname

More information about the llvm-commits mailing list