[PATCH] D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 03:16:32 PDT 2017


zvi added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35810
+  // TODO: After we improve lowerBuildVector, add execption for VPERMW.
+  return (SrcVT.getScalarSizeInBits() != 32 && Subtarget.hasAVX2());
+
----------------
RKSimon wrote:
> No, this should be an early-out:
> ```
> if (SrcVT.getScalarSizeInBits() == 32 || !Subtarget.hasAVX2())
>   return false;
> ```
Whoops this is not what i intended to upload.


https://reviews.llvm.org/D35700





More information about the llvm-commits mailing list