[PATCH] D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run"

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 02:11:02 PDT 2017


delcypher added a comment.

Other than criticisms of my own code :p LGTM.



================
Comment at: utils/lit/CMakeLists.txt:10
+# build directory just before running them. The tests are not copied over at
+# configure time (i.e. ``file(COPY ...)``) because this could lead to stale
+# tests being run.
----------------
Minor nit (criticising my own code here :p). Should be should be single ` , not double. 


================
Comment at: utils/lit/tests/lit.cfg:32
+  # ``src_root`` may be in LLVM's binary build directory which does not contain
+  # ``lit.py``, so use ``llvm_src_root`` instead.
+  lit_path = os.path.join(llvm_src_root, 'utils', 'lit')
----------------
Minor nits (criticising my own code here :p). Should be should be single ` , not double. 


https://reviews.llvm.org/D35880





More information about the llvm-commits mailing list