[llvm] r309075 - [gold] Enable data-sections by default for the gold-plugin.

[Davide Italiano via llvm-commits]

Author: davide
Date: Tue Jul 25 18:47:17 2017
New Revision: 309075

URL: http://llvm.org/viewvc/llvm-project?rev=309075&view=rev
Log:
[gold] Enable data-sections by default for the gold-plugin.

Follow up to r309056.

Added:
    llvm/trunk/test/tools/gold/X86/Inputs/multiple-data.ll
    llvm/trunk/test/tools/gold/X86/multiple-data.s
Modified:
    llvm/trunk/tools/gold/gold-plugin.cpp

Added: llvm/trunk/test/tools/gold/X86/Inputs/multiple-data.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/Inputs/multiple-data.ll?rev=309075&view=auto
==============================================================================
--- llvm/trunk/test/tools/gold/X86/Inputs/multiple-data.ll (added)
+++ llvm/trunk/test/tools/gold/X86/Inputs/multiple-data.ll Tue Jul 25 18:47:17 2017
@@ -0,0 +1,6 @@
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+ at pat = global i32 33, align 4
+ at tin = global i32 33, align 4
+ at dipsy = global i32 33, align 4

Added: llvm/trunk/test/tools/gold/X86/multiple-data.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/multiple-data.s?rev=309075&view=auto
==============================================================================
--- llvm/trunk/test/tools/gold/X86/multiple-data.s (added)
+++ llvm/trunk/test/tools/gold/X86/multiple-data.s Tue Jul 25 18:47:17 2017
@@ -0,0 +1,28 @@
+# RUN: echo ".data.tin" > %t_order_lto.txt
+# RUN: echo ".data.dipsy" >> %t_order_lto.txt
+# RUN: echo ".data.pat" >> %t_order_lto.txt
+
+# RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-unknown-linux-gnu
+# RUN: llvm-as %p/Inputs/multiple-data.ll -o %t2.o
+# RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
+# RUN:     -m elf_x86_64 -o %t.exe %t2.o %t.o  \
+# RUN:     --section-ordering-file=%t_order_lto.txt
+# RUN: llvm-readobj -elf-output-style=GNU -t %t.exe | FileCheck %s
+
+# CHECK: Symbol table '.symtab' contains 9 entries:
+# CHECK-NEXT:    Num:    Value          Size Type    Bind   Vis      Ndx Name
+# CHECK-NEXT:      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND
+# CHECK-NEXT:      1: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS ld-temp.o
+# CHECK-NEXT:      2: 0000000000401104     0 NOTYPE  GLOBAL DEFAULT  ABS _end
+# CHECK-NEXT:      3: 0000000000401104     0 NOTYPE  GLOBAL DEFAULT  ABS __bss_start
+# CHECK-NEXT:      4: 0000000000401104     0 NOTYPE  GLOBAL DEFAULT  ABS _edata
+# CHECK-NEXT:      5: 00000000004000e8     0 NOTYPE  GLOBAL DEFAULT    1 _start
+# CHECK-NEXT:      6: 00000000004010fc     4 OBJECT  GLOBAL DEFAULT    2 dipsy
+# CHECK-NEXT:      7: 00000000004010f8     4 OBJECT  GLOBAL DEFAULT    2 tin
+# CHECK-NEXT:      8: 0000000000401100     4 OBJECT  GLOBAL DEFAULT    2 pat
+
+.globl _start
+_start:
+  movl $pat, %ecx
+  movl $dipsy, %ebx
+  movl $tin, %eax

Modified: llvm/trunk/tools/gold/gold-plugin.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=309075&r1=309074&r2=309075&view=diff
==============================================================================
--- llvm/trunk/tools/gold/gold-plugin.cpp (original)
+++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Jul 25 18:47:17 2017
@@ -750,8 +750,9 @@ static std::unique_ptr<LTO> createLTO()
   // FIXME: Check the gold version or add a new option to enable them.
   Conf.Options.RelaxELFRelocations = false;
 
-  // Enable function sections by default.
+  // Enable function/data sections by default.
   Conf.Options.FunctionSections = true;
+  Conf.Options.DataSections = true;
 
   Conf.MAttrs = MAttrs;
   Conf.RelocModel = RelocationModel;