[PATCH] D35853: [DWARF] Generalized verification of .apple_names accelerator table to be applicable to any acceleration table. Added verification for .apple_types, .apple_namespaces and .apple_objc sections.

Spyridoula Gravani via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 17:53:26 PDT 2017

sgravani added inline comments.

Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:567
+    NumErrors +=
+        verifyAccelTable(&D.getAppleNamesSection(), &StrData, ".apple_names");
+  if (!D.getAppleTypesSection().Data.empty())
aprantl wrote:
> One last thing: You should not need to hard-code the name here. Can you extract it from the Section datastructure instead?
I'm not sure how to do this. Even dumpAccelSection() in DWARFContext.cpp is being called with the name of the section as an argument.



More information about the llvm-commits mailing list