[PATCH] D35852: Quote '?' in llvm-rc test

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 14:39:23 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D35852#820686, @mnbvmar wrote:

> It seems that single-quotes fail on Windows ('/h' is considered a whole argument, including the quotes). Double-quotes should work, though.


We don't actually use cmd to run tests on Windows, so the single quotes should work. We use lit's internal shell, which is effectively a limited implementation of bash.


https://reviews.llvm.org/D35852





More information about the llvm-commits mailing list