[PATCH] D35792: [lld] [COFF, ARM64] Handle ADRP immediate offsets in relocations

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 12:04:11 PDT 2017

ruiu added inline comments.

Comment at: COFF/Chunks.cpp:187
+// (RangeLimit).
+static void applyArm64Imm(uint8_t *Off, uint64_t Imm, uint32_t RangeLimit = 0) {
   uint32_t Orig = read32le(Off);
We do not use optional parameters that often, as it basically defines two or more functions with the same name which increases program complexity (even though the increase may be small.) Just pass 0 instead.

Comment at: test/COFF/arm64-symbol-offset.yaml:1
+# REQUIRES: aarch64
Can you reduce the size of the test? I don't think you need a test case of 200 lines to verify this change.


More information about the llvm-commits mailing list