[PATCH] D35843: [ELF] - Fix "--symbol-ordering-file doesn't work with linker scripts"

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Config.h:80
+  // A map from section to it's priority.
+  llvm::DenseMap<SectionBase *, int> SectionsOrder;
+  std::vector<llvm::StringRef> Symbols;
----------------
SectionsOrder -> SectionOrder

I don't think it is a good idea to make this available everywhere. Please just keep `SymbolOrderingFile` like before. When you need SectionOrder, compute it and store it to a local variable.


================
Comment at: ELF/LinkerScript.cpp:303
+
+static void sortBySymbolsOrder(InputSection **Begin, InputSection **End) {
+  if (Config->SymbolOrderingFile.SectionsOrder.empty())
----------------
SymbolsOrder -> SymbolOrder


https://reviews.llvm.org/D35843