[PATCH] D33362: [Polly][WIP]JSCoP Importer: support for multi-valued schedules

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Sorry for my absence, I was too busy with other stuff. If you don't get a response within a week or so, you can write a new comment "ping" so we don't forget.

In https://reviews.llvm.org/D33362#775904, @Mike_Jongen wrote:

> > Can you update the patch? It also seems your new files are not marked as being created. What are you using to create the diff?
>
> I use "git diff" for the creation of the diff. I used "git add -N" for adding the new files.


With `git add -N`, make sure that the diff is against a revision before you executed that command. For instance, `git diff HEAD`.

I'll wait to do a more thorough review when you rebased to the latest Polly trunk. E.g. `getAccessRelation()` changed to an C++ object. Use `getAccessRelation().release()` to get the C struct as before or use the C++ object itself (e.g. `NewAccessRel.set_tuple_id(...)`)



================
Comment at: lib/Analysis/ScopInfo.cpp:1660-1661
+        isl_map_set_tuple_name(NewAccessRel, isl_dim_in, getBaseName());
+    NewAccessRel =
+        isl_map_set_tuple_id(NewAccessRel, isl_dim_in, isl_id_copy(Id));
+    MemoryAccess *NewAccess =
----------------
Setting the tuple id will overwrite the change of the tuple name the line before.

`isl_map_set_tuple_name` is nothing more than `isl_map_set_tuple_id` with an `isl_id` of that name.


================
Comment at: lib/Exchange/JSONExporter.cpp:453
+
+bool unionMapIsBounded(isl_union_map *Map) {
+  if (isl_union_map_foreach_map(Map, &mapIsBounded, NULL) == isl_stat_ok) {
----------------
This function can be `static`


https://reviews.llvm.org/D33362