[PATCH] D34982: [Polly][WIP] Fully-Indexed static expansion

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: lib/Transform/MaximalStaticExpansion.cpp:193
+        // Get the domain of the future Read access.
+        auto ReadDomainSet = isl::give(isl_map_domain(MA->getAccessRelation()));
+        auto ReadDomain = isl::union_set(ReadDomainSet);
----------------
I get a compile error here. `MA->getAccessRelation()` has been updated to use C++ object. Please update to Polly trunk.


================
Comment at: lib/Transform/MaximalStaticExpansion.cpp:339
+
+void MaximalStaticExpander::emitRemark(Scop &S, std::string Msg) {
+  auto BB = S.getEnteringBlock();
----------------
[Suggestion] Pass string as `llvm::StringRef` (or `const std::string &` to avoid a copy)


================
Comment at: test/MaximalStaticExpansion/partial_access.ll:1
+; RUN: opt -polly-canonicalize %loadPolly -analyze -polly-opt-mse < %s 2>&1 | FileCheck %s 
+;
----------------
[Style] Please remove trailing whitespace.


https://reviews.llvm.org/D34982