[PATCH] D35835: [ARM] Use Swift error registers on non-Darwin targets

Arnold Schwaighofer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 08:15:28 PDT 2017

aschwaighofer requested changes to this revision.
aschwaighofer added a comment.
This revision now requires changes to proceed.

The change looks good but can you add a test case to test/CodeGen/ARM/swifterror.ll that r8 is not spilled say for a target triple of 'armv7-linux-androideabi'. For example, the function params_and_return_in_reg should not spill r8 as part of CSR spilling.

You would add the following run line to that file:

  ; RUN: llc -verify-machineinstrs < %s -mtriple=armv7-linux-androideabi | FileCheck --check-prefix=CHECK-ANDROID %s

And then copy the check located next to the params_and_return_in_reg function but for 'CHECK-ANDROID'.

Thank you for the contribution!


More information about the llvm-commits mailing list