[PATCH] D35703: [GPGPU] Add support for NVIDIA libdevice

[Siddharth via Phabricator via llvm-commits]

bollu accepted this revision.
bollu added a comment.
This revision is now accepted and ready to land.

Other than nits, LGTM



================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:1341
+/// A list of functions that are available in NVIDIA's libdevice.
+std::set<std::string> CUDALibDeviceFunctions = {"exp",  "expf", "expl", "cos",
+                                                "cosf", "sqrt", "sqrtf"};
----------------
this can be `const std::set<std::string> ...` ? I do not see us mutating this, and it would be nice to communicate this fact.


================
Comment at: test/lit.site.cfg.in:37
+# directories.
+config.excludes = ['Inputs']
+
----------------
Can we be more explicit and mention that these are for the `libdevice` tests?


https://reviews.llvm.org/D35703