[PATCH] D35793: [ELF] - Change way how we handle --noinhibit-exec

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:50:37 PDT 2017


>> -  if (Config->UnresolvedSymbols == UnresolvedPolicy::WarnAll ||
>> +  if (Config->NoinhibitExec ||
>>        (Config->UnresolvedSymbols == UnresolvedPolicy::Warn && CanBeExternal)) {
>>      warn(Msg);
>>    } else {
>
>Instead of checking NoinhibitExec you can replace the error in the else
>with errorOrWarn, no?
>
>That way there are two uses of errorOrWarn and we check NoinhibitExec in
>one place.
>
>Cheers,
>Rafael

Yes, thanks. And also there is one more place required for D35724 
I did not include to this patch initially because tried to reduce it,
so it will be 3 I think. Will update it soon

George.


More information about the llvm-commits mailing list