[PATCH] D35793: [ELF] - Change way how we handle --noinhibit-exec

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:47:01 PDT 2017

>The intention is to prevent almost all errors, no? So maybe you want to
>check NoinhibitExec in error() and the places that do have to fail can use

I tried to do something like this in initial diff of: https://reviews.llvm.org/D35724?id=107665,
but changed to current approach right after that, because I found it to much aggressive strategy.
Option saying "Retain the executable output file whenever it is still usable" but we currently
often do early returns when have errorCount>0 and it hard to say what logic is skipped and whether
output is 'usable'.

And I think we were trying to avoid 'fatal' errors as much as possible, I would probably not change
this strategy because of --noinhibit-exec.


More information about the llvm-commits mailing list