[PATCH] D35811: A workaround for the bug caused by descrepancy between loop-unswitch and GVN about branch on undef

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 23:58:02 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:1161
+  // FIXME: Remove this workaround when freeze related patches are done.
+  // For select with undef operand which feeds into an equality comparison,
+  // don't simplify it so loop unswitch can know the equality comparison
----------------
Is it better to document the bug number here?


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:556
 
+/// FIXME: Remove this workaround when freeze related patches are done.
+/// LoopUnswitch and Equality propagation in GVN have discrepancy about
----------------
Document the bug number?


Repository:
  rL LLVM

https://reviews.llvm.org/D35811





More information about the llvm-commits mailing list