[PATCH] D35818: [scudo] Check for pvalloc overflow

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 17:05:30 PDT 2017


alekseyshl accepted this revision.
alekseyshl added a comment.
This revision is now accepted and ready to land.

Yep, please do it other sanitizers too. Seems like a reasonable change.



================
Comment at: test/scudo/memalign.cpp:93
+    // Size passed to pvalloc overflows when rounded up.
+    p = pvalloc((size_t)-1);
+    assert(!p);
----------------
Spaces around -


================
Comment at: test/scudo/memalign.cpp:97
+    errno = 0;
+    p = pvalloc((size_t)-page_size);
+    assert(!p);
----------------
Ditto


https://reviews.llvm.org/D35818





More information about the llvm-commits mailing list