[PATCH] D35791: [COFF, ARM64] Fix symbol offsets in ADRP/ADD/LDR/STR relocations

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 13:15:41 PDT 2017

On Mon, 24 Jul 2017, Rafael Avila de Espindola wrote:

> Martin Storsjö via Phabricator <reviews at reviews.llvm.org> writes:
>>    case AArch64::fixup_aarch64_pcrel_adrp_imm21:
>> +    if (TheTriple.isOSBinFormatCOFF())
>> +      return AdrImmBits(Value & 0x1fffffULL);
> Do you want to do this even when IsResolved is true? From the
> description it looks like a property of when a relocation is created.

I'm not quite sure if this ever happens with IsResolved == true (see SVN 
r308518, we try to force relocations for all adrp, even though if the 
target is resolvable), but just in case for clarity, I updated the patch 
to check it.

// Martin

More information about the llvm-commits mailing list