[PATCH] D35115: X86 Asm should produce error messages instead of assertions when it's possible

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 10:49:07 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.

LGTM with one minor



================
Comment at: test/MC/X86/intel-syntax2.s:2
+// RUN: not llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel %s 2> %t.err
+// RUN: FileCheck --check-prefix=CHECK-STDERR < %t.err %s
+
----------------
Very minor but please call this file intel-syntax-3.s (we already have a intel-syntax-2.s).


https://reviews.llvm.org/D35115





More information about the llvm-commits mailing list