[llvm] r308900 - [CMake] Remove redundant logic in runtimes/CMakeList.txt

Leo Li via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 10:26:28 PDT 2017


Author: aoli
Date: Mon Jul 24 10:26:28 2017
New Revision: 308900

URL: http://llvm.org/viewvc/llvm-project?rev=308900&view=rev
Log:
[CMake] Remove redundant logic in runtimes/CMakeList.txt

Summary:
`SUB_CHECK_TARGETS` contains all test targets in `SUB_COMPONENTS` when
we load `Components.cmake`. We don't need to add those targets
again and having duplicate targets will break the cmake policy CMP0002.

Reviewers: phosek

Subscribers: mgorny, llvm-commits, srhines, pirama

Differential Revision: https://reviews.llvm.org/D35692

Modified:
    llvm/trunk/runtimes/CMakeLists.txt

Modified: llvm/trunk/runtimes/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/runtimes/CMakeLists.txt?rev=308900&r1=308899&r2=308900&view=diff
==============================================================================
--- llvm/trunk/runtimes/CMakeLists.txt (original)
+++ llvm/trunk/runtimes/CMakeLists.txt Mon Jul 24 10:26:28 2017
@@ -367,9 +367,6 @@ else() # if this is included from LLVM's
 
       if(LLVM_INCLUDE_TESTS)
         list(APPEND test_targets runtimes-test-depends check-runtimes)
-        foreach(component ${SUB_COMPONENTS})
-          list(APPEND SUB_CHECK_TARGETS check-${component})
-        endforeach()
       endif()
 
       llvm_ExternalProject_Add(runtimes




More information about the llvm-commits mailing list