[PATCH] D35793: [ELF] - Change way how we handle --noinhibit-exec

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 10:05:12 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:915
       if (!Target->isPicRel(Type))
-        error("relocation " + toString(Type) +
-              " cannot be used against shared object; recompile with -fPIC" +
-              getLocation<ELFT>(Sec, Body, Offset));
+        errorOrWarn(
+            "relocation " + toString(Type) +
----------------
This is the only place you are using `errorOrWarn`, so don't add that function just for -noinbhiti-exec.


https://reviews.llvm.org/D35793





More information about the llvm-commits mailing list