[PATCH] D35703: [GPGPU] Add support for NVIDIA libdevice

[Siddharth via Phabricator via llvm-commits]

bollu added inline comments.


================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:1314
+/// A list of functions that are available in NVIDIA's libdevice.
+std::vector<std::string> LibDeviceFunctions = {"exp", "expf", "expl", "cos",
+                                               "cosf"};
----------------
bollu wrote:
> Consider changing to `SmallSet`? That feels correct in terms of semantics (a `set` of functions.)
could you also please add `sqrt` to the list? this is present in the `COSMO` kernel.


https://reviews.llvm.org/D35703