[PATCH] D35724: [ELF] - Fix missing relocation when linking executable with --unresolved-symbols=ignore-all

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 00:14:29 PDT 2017

grimar added a comment.

In https://reviews.llvm.org/D35724#817642, @ruiu wrote:

> Looks like what you described in the commit message is different from what this patch actually does.

Logic supporting what is desctibed in commit message was implemented in includeInDynsym(),
but I had to change how we handle --noinhibit_exec because few out testcase started to fail.

> This patch is to handle the --noinhibit_exec option which wasn't handled before.

Actually we already handled it, but in a local way, it affected undefined symbols policy:

  static UnresolvedPolicy getUnresolvedSymbolPolicy(opt::InputArgList &Args) {
    // -noinhibit-exec or -r imply some default values.
    if (Args.hasArg(OPT_noinhibit_exec))
      return UnresolvedPolicy::WarnAll;

I'll try to split --noinhibit exec change to a different patch.


More information about the llvm-commits mailing list