[PATCH] D35767: [COFF] Correctly set the thumb bit in DLL export addresses

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Does link actually set the ISA selection bit on the EAT entries?  I don't remember that behaviour from it and I dont have it on hand to check.



================
Comment at: COFF/DLL.cpp:331
       } else {
-        write32le(P, cast<Defined>(E.Sym)->getRVA());
+        write32le(P, cast<Defined>(E.Sym)->getRVA() + Offset);
       }
----------------
Don't use `+1`.  If the ISA selection bit is set, then you will have erased it.


https://reviews.llvm.org/D35767