[PATCH] D35720: [AArch64] Reserve a 16 byte aligned amount of fixed stack for win64 varargs

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 22 14:36:01 PDT 2017


mstorsjo updated this revision to Diff 107803.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Updated the code to be consistent and use generic expressions for the size of the filler, instead of hardcoding 8 bytes. Added a comment to indicate that it in practice always will be 8 anyway.

Added a larger testcase for the case where the previous code broke down, where a local stack allocation clobbered a callee saved register. (This is stripped down from building parts of the MS ucrt headers - is this ok, or should I skip it?)


https://reviews.llvm.org/D35720

Files:
  lib/Target/AArch64/AArch64ISelLowering.cpp
  test/CodeGen/AArch64/aarch64_win64cc_vararg.ll
  test/CodeGen/AArch64/win64_vararg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35720.107803.patch
Type: text/x-patch
Size: 4414 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170722/6d88965a/attachment.bin>


More information about the llvm-commits mailing list