[PATCH] D35435: [AMDGPU] Produce flat|global_dwordx3 instructions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D35435#817806, @arsenm wrote:

> In https://reviews.llvm.org/D35435#817511, @rampitec wrote:
>
> > In https://reviews.llvm.org/D35435#817506, @arsenm wrote:
> >
> > > I could probably get the v3 patch in. IIRC I had all tests passing with a hack to keep the legalization unchanged and then got stuck fixing all cases with proper legalization
> >
> >
> > If legal v3 is around that is certainly preferable.
>
>
> https://github.com/arsenm/llvm/tree/legal-vector3-v2
>
> The first 2 commits here seem to work without test failures (but a few cost model regressions). They succeed in adding the basic types, the few after that need some more work


I wander what happens to passes which like to split a vector by half? I also can see that vectorizer (load/store and SLP) for instance is written in a way that does not support non power of 2 vectors. I hope some passes will just silently bail instead of silently fail at least when v3* will be reported as legal.

Anyway, if you are planning to fix these patches and merge I will hold current review. It also does not solve v3 operations problem other than load and potentially store, because v3 will be promoted on any arithmetic, so it is way not perfect.


https://reviews.llvm.org/D35435