[lld] r308706 - [ELF] Remove processNonSectionCommands

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 16:35:29 PDT 2017


Thanks!
Petr Hosek via llvm-commits <llvm-commits at lists.llvm.org> writes:

> Author: phosek
> Date: Thu Jul 20 18:02:30 2017
> New Revision: 308706
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308706&view=rev
> Log:
> [ELF] Remove processNonSectionCommands
>
> This method is no longer being used anywhere.
>
> Differential Revision: https://reviews.llvm.org/D35706
>
> Modified:
>     lld/trunk/ELF/LinkerScript.cpp
>     lld/trunk/ELF/LinkerScript.h
>
> Modified: lld/trunk/ELF/LinkerScript.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=308706&r1=308705&r2=308706&view=diff
> ==============================================================================
> --- lld/trunk/ELF/LinkerScript.cpp (original)
> +++ lld/trunk/ELF/LinkerScript.cpp Thu Jul 20 18:02:30 2017
> @@ -790,15 +790,6 @@ void LinkerScript::adjustSectionsAfterSo
>    removeEmptyCommands();
>  }
>  
> -void LinkerScript::processNonSectionCommands() {
> -  for (BaseCommand *Base : Opt.Commands) {
> -    if (auto *Cmd = dyn_cast<SymbolAssignment>(Base))
> -      assignSymbol(Cmd, false);
> -    else if (auto *Cmd = dyn_cast<AssertCommand>(Base))
> -      Cmd->Expression();
> -  }
> -}
> -
>  void LinkerScript::allocateHeaders(std::vector<PhdrEntry> &Phdrs) {
>    uint64_t Min = std::numeric_limits<uint64_t>::max();
>    for (OutputSectionCommand *Cmd : OutputSectionCommands) {
>
> Modified: lld/trunk/ELF/LinkerScript.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.h?rev=308706&r1=308705&r2=308706&view=diff
> ==============================================================================
> --- lld/trunk/ELF/LinkerScript.h (original)
> +++ lld/trunk/ELF/LinkerScript.h Thu Jul 20 18:02:30 2017
> @@ -288,7 +288,6 @@ public:
>  
>    bool shouldKeep(InputSectionBase *S);
>    void assignOffsets(OutputSectionCommand *Cmd);
> -  void processNonSectionCommands();
>    void assignAddresses();
>    void allocateHeaders(std::vector<PhdrEntry> &Phdrs);
>    void addSymbol(SymbolAssignment *Cmd);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list