[PATCH] D35165: [sanitizer] Support compiler-rt builtins

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: CMakeLists.txt:97
 
+option(SANITIZER_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
+
----------------
Maybe a bit more specific name and comment, SANITIZER_USE_COMPILER_RT_BUILTINS


================
Comment at: CMakeLists.txt:228
 
+# Set common link flags
+append_list_if(COMPILER_RT_HAS_NODEFAULTLIBS_FLAG -nodefaultlibs SANITIZER_COMMON_LINK_FLAGS)
----------------
Add dot at the end


================
Comment at: CMakeLists.txt:237
+  append_list_if(COMPILER_RT_HAS_GCC_S_LIB gcc_s SANITIZER_COMMON_LINK_LIBS)
+endif()
+
----------------
append_list_if(COMPILER_RT_HAS_LIBC c SANITIZER_COMMON_LINK_LIBS)

and we will not have to do it in every single sanitizer


Repository:
  rL LLVM

https://reviews.llvm.org/D35165