[PATCH] D35725: [LV] Avoid redundant operations manipulating masks

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 14:26:28 PDT 2017


Ayal added a comment.

In https://reviews.llvm.org/D35725#817510, @mssimpso wrote:

> This looks fine to me, but I don't quite follow why the patch is needed. Are we just trying to match what the VPlan recipe will eventually do?


As we provide patches of VPlan modelling, we're also trying to cleanup ILV's existing functionality, as in the ValueMap case. It's also possible to model ILV's existing functionality as-is, including redundant operations. But such cleanups seem desirable by themselves, and also help simplify the new modelling being introduced.

This patch is independent of https://reviews.llvm.org/D32871 which is still pending; it is preparing for a VPlan patch to follow https://reviews.llvm.org/D32871.


https://reviews.llvm.org/D35725





More information about the llvm-commits mailing list