[PATCH] D34601: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess.

[David Kreitzer via Phabricator via llvm-commits]

DavidKreitzer added inline comments.


================
Comment at: lib/Target/X86/X86InterleavedAccess.cpp:188
+
+static Value* CreateShuffleVector(IRBuilder<> &B, Value *V1, Value *V2,
+                                    ArrayRef<int32_t> IntMask,
----------------
Ugh! I didn't realize that you were going to have to add this method to do the ArrayRef conversion. Sorry, I think I gave you bad advice. I think this is a worse evil than the explicit template arguments in the previous patch.

Unless someone else has a better idea, my recommendation is to go back to your previous solution and accept the explicit template arguments as an unfortunate consequence of the inconsistent ShuffleVector interfaces.



https://reviews.llvm.org/D34601