[PATCH] D35522: Move Runtime libcall definitions to a .def file

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 10:10:40 PDT 2017


dschuff added a comment.

Actually, maybe an even better idea:
`getLibcallName()` returns a StringRef and asserts rather than returning a failure code. `getLIbcallNameIfAvailable()` returns an Expected<StringRef> and can fail.
The former matches  90% of the existing uses. This would let us move away from char* for the external symbol APIs (assuming that's a good thing) but most of the existing uses wouldn't need to actually change, and those that check failure would still be simple.


Repository:
  rL LLVM

https://reviews.llvm.org/D35522





More information about the llvm-commits mailing list