[PATCH] D35586: [ProfData] Detect if zlib is available

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 08:56:57 PDT 2017


dblaikie added a comment.

In https://reviews.llvm.org/D35586#817181, @chenwj wrote:

> @dblaikie ping? :-)


Oh, sorry - I already approved this. Approval with comments usually means "I assume the requested changes are simple/clear/obvious enough to not require another round of review", etc.

In any case - looks good to commit after the "REGENERATE:" prefixes are removed. (did you see the discussion on the mailing list? Not all emails get reflected in Phabricator, and I replied to your question about the REGENERATE Prefix directly on the mailing list - I removed it in the other test that used it, so please remove it from this one before committing)


https://reviews.llvm.org/D35586





More information about the llvm-commits mailing list