[llvm] r257571 - [Coverage] Refactor coverage mapping reader code

[Alex L via llvm-commits]

Joerg,

Are you talking about the "non-default #pragma pack value might change the
alignment of struct or union members in the included file" warning? If yes,
that commit got reverted (before 5.0 branch I think). I'm working on a
fixed commit that would avoid this particular warning.

Alex

On 21 July 2017 at 11:48, Joerg Sonnenberger via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Wed, Jan 13, 2016 at 04:36:15AM -0000, Xinliang David Li via
> llvm-commits wrote:
> > Modified: llvm/trunk/include/llvm/ProfileData/CoverageMapping.h
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/
> llvm/ProfileData/CoverageMapping.h?rev=257571&
> r1=257570&r2=257571&view=diff
> > ============================================================
> ==================
> > --- llvm/trunk/include/llvm/ProfileData/CoverageMapping.h (original)
> > +++ llvm/trunk/include/llvm/ProfileData/CoverageMapping.h Tue Jan 12
> 22:36:15 2016
> > @@ -479,14 +489,50 @@ inline std::error_code make_error_code(c
> >  // [Encoded Region Mapping Data]
> >  LLVM_PACKED_START
> >  template <class IntPtrT> struct CovMapFunctionRecord {
> > -  #define COVMAP_FUNC_RECORD(Type, LLVMType, Name, Init) Type Name;
> > -  #include "llvm/ProfileData/InstrProfData.inc"
> > +#define COVMAP_FUNC_RECORD(Type, LLVMType, Name, Init) Type Name;
> > +#include "llvm/ProfileData/InstrProfData.inc"
>
> This part now triggers a warning that the default packed attribute via
> LLVM_PACKED_START affects the types in the included file. Is that
> intentional? This applies to the 5.0 branch as well.
>
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170721/0bdb8d76/attachment.html>