[PATCH] D34716: [AMDGPU] Add pseudo "old" and "wqm_mode" source to all DPP instructions

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 14:58:50 PDT 2017


nhaehnle added a comment.

One question, apart from that looks good.



================
Comment at: lib/Target/AMDGPU/VOP2Instructions.td:278
 
-  let InsDPP = (ins Src0Mod:$src0_modifiers, Src0DPP:$src0,
+  let InsDPP = (ins i8imm:$wqm_ctrl, DstRCDPP:$old,
+                    Src0Mod:$src0_modifiers, Src0DPP:$src0,
----------------
Is the wqm_ctrl still correct?


https://reviews.llvm.org/D34716





More information about the llvm-commits mailing list