[PATCH] D35639: [LTO] Prevent dead stripping and internalization of symbols with sections

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 14:46:55 PDT 2017


mehdi_amini added inline comments.


================
Comment at: lib/LTO/LTO.cpp:391
+    // __start_<secname> and __end_<secname> symbols which may be used
+    // elsewhere.
     if (Res.LinkerRedefined || Res.VisibleToRegularObj || Sym.isUsed() ||
----------------
I don't understand why this is the right place to do this? Why isn't the responsibility of the linker resolution to mark these symbols as externally visible?


https://reviews.llvm.org/D35639





More information about the llvm-commits mailing list