[llvm] r308062 - [Dominators] Implement incremental deletions

[Tobias Grosser via llvm-commits]

Hi Jakub,

some small post-commit comments:

On Fri, Jul 14, 2017, at 11:58 PM, Jakub Kuderski via llvm-commits
wrote:
> Author: kuhar
> Date: Fri Jul 14 14:58:53 2017
> New Revision: 308062
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=308062&view=rev
> Log:
> [Dominators] Implement incremental deletions
> +  /// tree is informed about makes some (domominator) subtree
> unreachable -- in

dominator

> +  // Checks if a node has proper support, as defined on the page 3 and
> later
> +  // explained on the page 7 of the second paper.

Very nice that you cite some paper, but which exactly is the "second
paper"? I could not find a reference in the code.

> +  // Handle deletions that make destination node unreachable.
> +  // (Based on the lemma 2.7 from the second paper.)

I also miss the second paper here.

> +    // Identify the top of the subtree to rebuilt by finding the NCD of

rebuild

Best,
Tobias