[PATCH] D35422: Add MemoryMappedSection struct for two-level memory map iteration

[Francis Ricci via Phabricator via llvm-commits]

fjricci added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:60
+
+#if SANITIZER_MAC
+
----------------
kcc wrote:
> Folks, please avoid ifdefs like this. 
> I'd appreciate if you can refactor the code to get rid of this ifdef (e.g move stuff to a separate file)
This file already has quite a few OS-based #ifdefs in it (which is why I didn't think adding another would be problematic). Is it worth trying to refactor in a way that they all go away, or just this one in particular?


Repository:
  rL LLVM

https://reviews.llvm.org/D35422