[PATCH] D35692: [CMake] Remove redundant logic in runtimes/CMakeList.txt

Leo Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 11:13:26 PDT 2017


aoli created this revision.
Herald added a subscriber: mgorny.

`SUB_CHECK_TARGETS` contains all test targets in `SUB_COMPONENTS` when
we load `Components.cmake`. We don't need to add those targets
again and having duplicate targets will break the cmake policy CMP0002.


https://reviews.llvm.org/D35692

Files:
  runtimes/CMakeLists.txt


Index: runtimes/CMakeLists.txt
===================================================================
--- runtimes/CMakeLists.txt
+++ runtimes/CMakeLists.txt
@@ -367,9 +367,6 @@
 
       if(LLVM_INCLUDE_TESTS)
         list(APPEND test_targets runtimes-test-depends check-runtimes)
-        foreach(component ${SUB_COMPONENTS})
-          list(APPEND SUB_CHECK_TARGETS check-${component})
-        endforeach()
       endif()
 
       llvm_ExternalProject_Add(runtimes


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35692.107562.patch
Type: text/x-patch
Size: 466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170720/0d7d1208/attachment.bin>


More information about the llvm-commits mailing list