[PATCH] D35688: More extendable LaneBitmask

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 10:49:58 PDT 2017


MatzeB added a comment.

- I would be slightly hesitant here, as it complicates code and none of the public targets needs this. We don't even try the "uint64_t" instead of "unsigned" step but instead just make it all complicated right away...
- I would not commit this without careful measurements to ensure that compilers indeed optimize all of this away and we don't have a compiletime impact.
- You probably can use some of the `APInt::tcXXX` functions to avoid code duplication.


Repository:
  rL LLVM

https://reviews.llvm.org/D35688





More information about the llvm-commits mailing list