[polly] r308512 - [CMake] Fix r307650: Readd missing dependency.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 09:37:17 PDT 2017


Sounds good to me. Tobias: is this ok to merge?

On Thu, Jul 20, 2017 at 6:04 PM, Philip Pfaffe <philip.pfaffe at gmail.com> wrote:
> Hi Hans,
>
> I think this commit should be merged into the release branch. It fixes the
> Polly check-polly build target in case opt, FileCheck, or similar weren't
> built.
>
> Cheers,
> Philip
>
> ---------- Forwarded message ----------
> From: Philip Pfaffe via llvm-commits <llvm-commits at lists.llvm.org>
> Date: 2017-07-19 21:20 GMT+02:00
> Subject: [polly] r308512 - [CMake] Fix r307650: Readd missing dependency.
> To: llvm-commits at lists.llvm.org
>
>
> Author: pfaffe
> Date: Wed Jul 19 12:20:58 2017
> New Revision: 308512
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308512&view=rev
> Log:
> [CMake] Fix r307650: Readd missing dependency.
>
> The commit erroneously removed the dependency of the Polly tests on
> things like opt and FileCheck. Add that dependency back.
>
> Modified:
>     polly/trunk/test/CMakeLists.txt
>
> Modified: polly/trunk/test/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/polly/trunk/test/CMakeLists.txt?rev=308512&r1=308511&r2=308512&view=diff
> ==============================================================================
> --- polly/trunk/test/CMakeLists.txt (original)
> +++ polly/trunk/test/CMakeLists.txt Wed Jul 19 12:20:58 2017
> @@ -28,14 +28,15 @@ if(NOT LLVM_MAIN_SRC_DIR)
>    if ("${POLLY_TEST_EXTRA_PATHS}" STREQUAL "${LLVM_TOOLS_BINARY_DIR}")
>      set(POLLY_TEST_EXTRA_PATHS "")
>    endif()
> +  set(POLLY_TEST_DEPS LLVMPolly)
>  else ()
>    set(LLVM_OPT "${LLVM_TOOLS_BINARY_DIR}/opt")
>    set(LLVM_FILECHECK "${LLVM_TOOLS_BINARY_DIR}/FileCheck")
>    set(LLVM_NOT "${LLVM_TOOLS_BINARY_DIR}/not")
>    set(POLLY_TEST_EXTRA_PATHS "")
> +  set(POLLY_TEST_DEPS llvm-config opt LLVMPolly FileCheck not)
>  endif()
>
> -set(POLLY_TEST_DEPS LLVMPolly)
>  if (POLLY_BUNDLED_ISL)
>    list(APPEND POLLY_TEST_DEPS polly-isl-test)
>  endif()
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list