[PATCH] D35586: [ProfData] Detect if zlib is available

[Xinliang David Li via llvm-commits]

On Thu, Jul 20, 2017 at 8:12 AM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
> On Thu, Jul 20, 2017 at 3:44 AM Wei-Ren Chen via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> chenwj added inline comments.
>>
>>
>> ================
>> Comment at: test/tools/llvm-profdata/nocompress.test:1-10
>> +REGENERATE: You need a checkout of clang with compiler-rt to generate the
>> +REGENERATE: binary file here.  These shell commands can be used to
>> regenerate
>> +REGENERATE: it.
>> +REGENERATE:
>> +REGENERATE: $ SRC=path/to/llvm
>> +REGENERATE: $ CFE=$SRC/tools/clang
>> +REGENERATE: $ TESTDIR=$SRC/test/tools/llvm-profdata
>> ----------------
>> dblaikie wrote:
>> > You don't need to use a prefix for these lines - since this file isn't
>> parsed by anything except Lit and FileCheck (which both only handle lines
>> with prefixes) any non-prefix lines are ignored/irrelevant and can be
>> freeform.
>> I just copy and modify the instructions from c-general.test. Do you still
>> want me remove those REGENERATE prefix?
>>
>
> Oh, good to know! Yes please (please remove the REGENERATE prefix) - and
> if you could (or I can/will), could you commit a separate change (no need
> for precommit review) to remove the prefix from the existing test?
>

Wen-Ren still needs commit access to do that -- so probably it is better
for you to clean it up ;)

David


>
>
>>
>>
>> https://reviews.llvm.org/D35586
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170720/d2f4208b/attachment.html>