[PATCH] D35517: Add the --chroot option for --reproduce.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 08:40:14 PDT 2017


The idea LGTM.

Please add a test showing that it works with / paths. That way the
windows bots will guard against the issue George noticed.

Bonus for adding a test that uses sysroot. I like having an option
called --chroot so that it is clearly independent of sysroot.

Cheers,
Rafael

Ed Maste via Phabricator via llvm-commits <llvm-commits at lists.llvm.org>
writes:

> emaste added a comment.
>
> Approach LGTM, modulo @grimar's issue. I wonder if we should call the option `--sysroot` (and make it available to users) though? We'd have a little more work to do to handle a user-supplied sysroot when creating reproducers.
>
>
> https://reviews.llvm.org/D35517
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list