[PATCH] D35633: [ThinLTO] Add FunctionAttr NoRecurse and ReadAttr propagation to ThinLTO

[Charles Saternos via Phabricator via llvm-commits]

ncharlie added inline comments.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:413
+  SmallSetVector<Function *, 8> SCCNodes;
+  for (Function &C : TheModule.getFunctionList()) {
+    SCCNodes.insert(&C);
----------------
I'm don't think this entirely correct. The reason I did it this way was so I could reuse the computeFunctionBodyMemoryAccess from the original FunctionAttrs pass. I think I'll need to modify that function a bit to work with the Index so it can access information about functions external to the current module.


https://reviews.llvm.org/D35633