[PATCH] D35586: [ProfData] Detect if zlib is available

Wei-Ren Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 03:44:00 PDT 2017


chenwj added inline comments.


================
Comment at: test/tools/llvm-profdata/nocompress.test:1-10
+REGENERATE: You need a checkout of clang with compiler-rt to generate the
+REGENERATE: binary file here.  These shell commands can be used to regenerate
+REGENERATE: it.
+REGENERATE:
+REGENERATE: $ SRC=path/to/llvm
+REGENERATE: $ CFE=$SRC/tools/clang
+REGENERATE: $ TESTDIR=$SRC/test/tools/llvm-profdata
----------------
dblaikie wrote:
> You don't need to use a prefix for these lines - since this file isn't parsed by anything except Lit and FileCheck (which both only handle lines with prefixes) any non-prefix lines are ignored/irrelevant and can be freeform.
I just copy and modify the instructions from c-general.test. Do you still want me remove those REGENERATE prefix?


https://reviews.llvm.org/D35586





More information about the llvm-commits mailing list