[PATCH] D35492: [DAGCombiner] Match non-uniform constant vectors using predicates (RFC).

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 21:58:53 PDT 2017


filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.

Ugh, implicit truncate/extend strikes again. I keep forgetting about those.
LGTM, I'm ok with the choice in the use of `MatchShiftTooBig`, but maybe add a tiny comment mentioning you picked the safer option?


Repository:
  rL LLVM

https://reviews.llvm.org/D35492





More information about the llvm-commits mailing list