[PATCH] D35551: Introduce sanitizer_procmaps_netbsd.cc

[Francis Ricci via Phabricator via llvm-commits]

fjricci added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_netbsd.cc:40
+
+bool MemoryMappingLayout::Next(uptr *start, uptr *end, uptr *offset,
+                               char filename[], uptr filename_size,
----------------
krytarowski wrote:
> vitalybuka wrote:
> > vitalybuka wrote:
> > >  MemoryMappingLayout::Next interface was changed
> > And entire file looks very similar to sanitizer_procmaps_freebsd.cc
> I'm going to rebase it.
> 
> Right, FreeBSD is similar.
If freebsd is sufficiently similar, it's probably worth it to just combine them and #ifdef any small differences (this is frequently done for Linux+Freebsd).


Repository:
  rL LLVM

https://reviews.llvm.org/D35551