[PATCH] D35425: Implement parsing and writing of a single xml manifest file.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 14:44:30 PDT 2017


ruiu added inline comments.


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:147
+    reportError("empty manifest not written");
+  } else {
+    ErrorOr<std::unique_ptr<FileOutputBuffer>> FileOrErr =
----------------
Since `reportError` is a noreturn function, remove `else`.


https://reviews.llvm.org/D35425





More information about the llvm-commits mailing list