[PATCH] D35619: [ELF] - Introduce multiclass JSEq helper for Options.td

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 13:03:49 PDT 2017


> @@ -805,7 +805,8 @@
>  void LinkerDriver::createFiles(opt::InputArgList &Args) {
>    for (auto *Arg : Args) {
>      switch (Arg->getOption().getID()) {
> -    case OPT_l:
> +    case OPT_alias_library:
> +    case OPT_library:
>        addLibrary(Arg->getValue());
>        break;
>      case OPT_INPUT:

Why do you need to check the alias in here?

Some of the lines now look over 80 columns.

LGTM with those nits fixed.

Cheers,
Rafael


More information about the llvm-commits mailing list