[PATCH] D35480: [mips] Support `long_call/far/near` attributes passed by front-end

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:3156
+  if (!Subtarget.isABICalls() && !IsPIC) {
+    if (auto *N = dyn_cast<ExternalSymbolSDNode>(Callee)) {
+      if (Subtarget.useLongCalls())
----------------
sdardis wrote:
> Restore the comment from lines 3156-3157 to an appropriate place.
> 
> Question (I haven't looked throughly yet): Can an ExternalSymbolSDNode have the long-call/near-call attribute?
> 
> If it can, then this expansion code is missing the portions that check the attributes of the ExternalSymbolSDNode.
> Can an ExternalSymbolSDNode have the long-call/near-call attribute?

As far as I understand the IR, `ExternalSymbolSDNode` cannot contains any attribute.


Repository:
  rL LLVM

https://reviews.llvm.org/D35480